[Stgt-devel] vtl patch.

[FUJITA Tomonori]

From: "Mark Harvey" <markh794 at gmail.com>
Subject: [Stgt-devel] vtl patch.
Date: Thu, 5 Apr 2007 09:56:10 +1000

> Apologies for this being an attachment. It is rather large to include
> inline (57k).
> 
> Follow up to feedback from earlier postings, I have implemented the following:
> 
> 
> This patch includes the following changes.
> 
> - Patch to tgtadm so multiple '--name, --value' arguments can be passed.

Why do we need multiple arguments?

I prefer to keep the current semantics:

$ tgtadm --lld iscsi --mode logicalunit --op update --tid=1 --lun=0 \
         -n VendorIdent -v QUANTUM
$ tgtadm --lld iscsi --mode logicalunit --op update --tid=1 --lun=0 \
         -n ProductIdent -v SDLT600
$ tgtadm --lld iscsi --mode logicalunit --op update --tid=1 --lun=0 \
         -n ProductRev -v 0001
$ tgtadm --lld iscsi --mode logicalunit --op update --tid=1 --lun=0 \
         -n SerialNumber -v XYZZY10

rather than:

tgtadm --lld iscsi --mode logicalunit --op update --tid=1 --lun=0 \
	-n VendorIdent -v QUANTUM	\
	-n ProductIdent -v SDLT600	\
	-n ProductRev -v 0001		\
	-n SerialNumber -v XYZZY10


The rest looks ok.