[stgt] [PATCH] show tgtd and tgtadm version

[FUJITA Tomonori]

On Tue, 16 Dec 2008 12:42:51 +0100
Tomasz Chmielewski <mangoo at wpkg.org> wrote:

> FUJITA Tomonori schrieb:
> 
> (...)
> 
> >> +#define TGT_VERSION "20081215"
> > 
> > Well, this force me to update TGT_VERSION every time I apply a patch.
> 
> Yeah, that's a pain.

I think that it's unrealistic.

Please tell me a maintainer who update the version string every time
he applies a single patch.


> What could be other options?

I think that you can put some magic to Makefile.

For example, Makefile detects if it's a git repository, you can put
the object name to TGT_VERSION:

fujita at viola:/tmp/tgt$ git-show-ref --heads --abbrev
5a21a44 refs/heads/master

So TGT_VERSION could be something like 0.9.2-5a21a44 if you compile
the git tree. As long as things are done automatically, it's fine by
me.

I guess that Debian's kernel build tool does similar things.


> Changing Makefile so that it uses git revision from 
> tgt/.git/refs/heads/master automatically (for version)? They are quite 
> hard to refer to for a casual user, i.e.: 
> 5a21a4472817b5e70fad3ca9736e7415471ff741

- I don't think that we consider users who fetch code from the git and
compile it, to be a casual user.

- You can use the abbreviation of the object name (as I did above).
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html