[stgt] segfault when stopping the target

[Tomasz Chmielewski]

Tomasz Chmielewski schrieb:
> FUJITA Tomonori schrieb:
> 
>>>>> --- SIGSEGV (Segmentation fault) @ 0 (0) ---
>>>>> +++ killed by SIGSEGV +++
>>>>> Process 5131 detached
>>>> This helps?
>>> At least it does not crash any more ;)
>>> But it loops endlessly.
>>
>> Ah, thanks.
>>
>> With this patch, tgtadm should fail properly instead of going into
>> endless loop.
>>
>> But we need to know why tgtd closed tgtadm's socket. Can you try this
>> patch and let me know if you get error messages in the log.
> 
> It does not seem to crash nor loop any more.
> 
> Does it say anything?
> 
> Oct 21 16:21:04 megathecus tgtd: conn_close_force(197) close 1 0
> Oct 21 16:21:04 megathecus tgtd: conn_close(88) connection closed 
> 0x80700b4 4
> Oct 21 16:21:04 megathecus tgtd: tgt_event_modify(159) Cannot find event 7

It's harder to reproduce now. Sometimes, it works dozen times in a row. 
Sometimes, it doesn't.


Sometimes, with these commands (started in a script) and a connected 
initiator, I get "tgtadm: this target unit is still active". Eventually, 
it will close the connection when I repeat these commands several times.


tgtadm --op update --mode target --tid=1 -n state -v offline
tgtadm --op update --mode sys --name State -v offline
tgtadm --op unbind --mode target --tid 1 -I ALL
tgtadm --op delete --mode conn --tid 1 --sid 1 --cid 0
tgtadm --mode target --op delete --tid=1



Oct 21 16:36:59 megathecus tgtd: conn_close_force(197) close 1 0
Oct 21 16:36:59 megathecus tgtd: conn_close(88) connection closed 
0x80700b4 3
Oct 21 16:36:59 megathecus tgtd: tgt_target_destroy(1739) target 1 still 
has it nexus



-- 
Tomasz Chmielewski
http://wpkg.org
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html