[stgt] [PATCH 1/1] Build process makeover

[Florian Haas]

On 10/02/2009 10:07 AM, Chris Webb wrote:
> Florian Haas <florian.haas at linbit.com> writes:
> 
>> A fairly thorough makeover of the build system, with one Makefile per
>> directory replacing the previous single Makefile in usr.
>>
>> This adds some version detection magic and a "make tarball" target for
>> conveniently rolling a tarball out of a git checkout.
> 
> Any chance of defining and using sbindir rather than hardcoding /usr/sbin,
> in the same way you define and use mandir and docdir?
> 
> I have to carry a patch against the current makefile for my systems which
> have neither /usr or /sbin, just /bin, but equally many people will want to
> configure to install into /usr/local/sbin. The annoyance of doing this will
> increase if we go from one makefile needing changing to lots of makefiles
> needing changing!

FWIW, installing something that's meant to be run only by root in /bin
is, if I'm not mistaken, an LSB violation. Installing into
/usr/local/sbin is a good point though. Adding an sbindir variable would
sound like a plan to me. Come to think of it, mandir and docdir should
be changed to be defined with "?=", not "=", so you can override from
the make command line and you only need to change your build scripts,
not patch any Makefiles.

Of course one could also tackle this problem with
configure/automake/autoconf insanity, but that might be a wee bit of
overkill. :)

Cheers,
Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <http://lists.wpkg.org/pipermail/stgt/attachments/20091002/f1696c75/attachment-0001.sig>