[stgt] [PATCH 1/3] Compile iser driver as a loadable module
agrover at redhat.com
Wed Oct 19 19:16:58 CEST 2011
On 10/19/2011 04:45 AM, Or Gerlitz wrote:
> On 10/14/2011 1:09 AM, Andy Grover wrote:
>> With iser being built in, the tgtd package pulls in two more
>> libraries, libibverbs and librdmacm, is the motivation here to
>> eliminate that as of the overhead?
>>> Yes. Admittedly not a huge issue, but tgt code is already
>>> modularized, so the entire change is to the Makefile, except for
>>> one line. So, any objections to this change? Going once...
> So how you envision possible packaging here, is that two rpms one
> with iser stripped tgt and the other containing the tgt iser code
> with the latter depending on the former and on the verbs/rdmacm
Yep, pretty much.
The only other thing I'd probably do at the rpm packaging stage is add a
patch to print an extra message when the user used "--lld iser" but it
wasn't found, along the lines of "please install <packagename> for iser
support". I don't know if that patch should go upstream, since I doubt
other packagers will use the same pkg name, or they may continue to
include the iser driver in the main package.
Regards -- Andy
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
More information about the stgt