[stgt] [PATCH v2] bs_rbd.c: pass cluster, not &cluster, to rados_shutdown()

Dan Mick dan.mick at inktank.com
Mon Oct 14 22:43:24 CEST 2013


Argh.  Yes, the patch snuck into the previous patchset, which is
already applied.  So sorry for the churn; I'm trying to maintain about 
five different branches here and failed on this one.

Not a big issue; the code is good, just not as separable as it would
ideally be, but I'm extremely sorry to waste your time.

On 10/14/2013 01:36 PM, FUJITA Tomonori wrote:
> On Mon, 14 Oct 2013 13:01:01 -0700
> Dan Mick <dan.mick at inktank.com> wrote:
>
>> Signed-off-by: Dan Mick <dan.mick at inktank.com>
>> ---
>>   usr/bs_rbd.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/usr/bs_rbd.c b/usr/bs_rbd.c
>> index f1dd77d..3abf1cf 100644
>> --- a/usr/bs_rbd.c
>> +++ b/usr/bs_rbd.c
>> @@ -515,7 +515,7 @@ static void bs_rbd_exit(struct scsi_lu *lu)
>>   	struct bs_thread_info *info = BS_THREAD_I(lu);
>>
>>   	bs_thread_close(info);
>> -	rados_shutdown(&cluster);
>> +	rados_shutdown(cluster);
>>   }
>
> I can't apply this. The code is not against the latest?
>
> https://github.com/fujita/tgt/blob/master/usr/bs_rbd.c#L510
>
> The previous patchset fixed the issue and you don't need this patch
> any more?
>
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



More information about the stgt mailing list