[sheepdog] [PATCH v2 04/11] sheep: don't check nodes information for joined nodes

MORITA Kazutaka morita.kazutaka at gmail.com
Wed Sep 18 19:42:54 CEST 2013


At Sat, 14 Sep 2013 18:34:24 +0800,
Liu Yuan wrote:
> 
> cluster_join_check is basically used to check newly joining node. But the old
> code also check the nodes states passed by cinfo with sys->cinfo. After we have
> struct rb_node rb in the sd_node, we'll never have this check passed.
> 
> Instead of doing the check with more complex code, this patch simply remove the
> check since nodes states in the joined nodes are always the same.

Is it true?  E.g. if network partition happens and two subclusters are
merged, the state of the joining node doesn't match.  The current code
can detect it, but this patch removes the check?

Thanks,

Kazutaka



More information about the sheepdog mailing list