[sheepdog] [PATCH v2 04/11] sheep: don't check nodes information for joined nodes

[Liu Yuan]

On Thu, Sep 19, 2013 at 02:42:54AM +0900, MORITA Kazutaka wrote:
> At Sat, 14 Sep 2013 18:34:24 +0800,
> Liu Yuan wrote:
> > 
> > cluster_join_check is basically used to check newly joining node. But the old
> > code also check the nodes states passed by cinfo with sys->cinfo. After we have
> > struct rb_node rb in the sd_node, we'll never have this check passed.
> > 
> > Instead of doing the check with more complex code, this patch simply remove the
> > check since nodes states in the joined nodes are always the same.
> 
> Is it true?  E.g. if network partition happens and two subclusters are
> merged, the state of the joining node doesn't match.  The current code
> can detect it, but this patch removes the check? 
> 

why we don't allow nodes that are network partitioned to join back? Users asks
to join the node, I think we should allow the node to join back, no?

Thanks
Yuan