[sheepdog] [PATCH] Fix some problems of Debian package

MORITA Kazutaka morita.kazutaka at gmail.com
Tue Sep 24 08:43:58 CEST 2013


Hi YunQiang,

Thanks for your contribution.

Can you split this patch into smaller ones for easier to review?

I'd suggest at least 7 patches.
 - add translation files
 - update URLs
 - fix the destination directory
 - modify the priority of sheepdog/start?
 - remove deprecated (and useless?) import
 - avoid creating symbolic link
 - remove a data directory when purge option is specified

> > --- a/debian/sheepdog.config
> > +++ b/debian/sheepdog.config
> > @@ -12,6 +12,7 @@ if [ -r /etc/default/sheepdog ] ; then
> >         fi
> >         db_set sheepdog/daemon_args "$DAEMON_ARGS"
> >  fi
> > +db_input low sheepdog/start || true
> >  db_input medium sheepdog/start || true

I'm not sure what is intended with this change.  Perhaps, you forgot
to remove the "db_input medium sheepdog/start" line?

> >  db_input medium sheepdog/daemon_args || true
> >  db_go || true
> > diff --git a/debian/sheepdog.init b/debian/sheepdog.init
> > index 648ce30..9b03564 100644
> > --- a/debian/sheepdog.init
> > +++ b/debian/sheepdog.init
> > @@ -36,9 +36,6 @@ if [ "$START" != "yes" ]; then
> >         exit 0
> >  fi
> >
> > -# Load the VERBOSE setting and other rcS variables
> > -. /lib/init/vars.sh
> > -
> It is deprecated now.

Can you explain what the script did and why we can safely remove it
now?

> >  # Define LSB log_* functions.
> >  # Depend on lsb-base (>= 3.0-6) to ensure that this file is present.
> >  . /lib/lsb/init-functions
> > diff --git a/debian/sheepdog.links b/debian/sheepdog.links
> > new file mode 100644
> > index 0000000..40940d1
> > --- /dev/null
> > +++ b/debian/sheepdog.links
> > @@ -0,0 +1 @@
> > +/usr/sbin/dog /usr/sbin/collie
> > diff --git a/debian/sheepdog.postinst b/debian/sheepdog.postinst
> > index c0d3c0f..bc72f06 100644
> > --- a/debian/sheepdog.postinst
> > +++ b/debian/sheepdog.postinst
> > @@ -24,8 +24,6 @@ if [ "$1" = "configure" ] ; then
> >         db_stop || true
> >  fi
> >
> > -ln -s -f /usr/sbin/dog /usr/sbin/collie
> > -
> Don't do it like, or it will escape from dpkg's track

We need /usr/sbin/collie for the backward compatibility.  Is there any
way to install /usr/sbin/collie?

Thanks,

Kazutaka



More information about the sheepdog mailing list